Design refactoring #817
Merged
Design refactoring #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again @ad619659! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring name: Extract class
Location: openhtmltopdf-core
Package: com.openhtmltopdf.layout
Class: CounterFunction
Extracted a new class from CounterFunction and moved two methods toRoman and toLatin. The refactoring reduces the size of the class and moves methods for cohesiveness.
Refactoring name: Pull-up method
Location: openhtmltopdf-core
Package: com.openhtmltopdf.context
Class: ContentFunctionFactory
Introduced a new layer of abstraction for improving code reusability. Moved isStatic method from subclasses to the intermediate abstract layer.
Refactoring name: Move method
Location: openhtmltopdf-core
Package: com.openhtmltopdf.css.style.derived
Class: FSLinearGradient
Extracted a new class a moved methods deg2rad, isLengthOrPercentage, getStopsStartIndex, get100PercentDefaultStopLength, and calculateAngle.
Best regards,
Aditya